Re: C6X port 7/11: Cope with odd section names

[Bernd Schmidt <bernds at codesourcery dot com>]

On 05/10/2011 06:55 PM, Joseph S. Myers wrote:
> 
> Unless the documentation is based on pre-existing GFDL-only documentation 
> in tm.texi.in, it's preferable for the documentation of a new hook to go 
> in the doc string in target.def and get to tm.texi that way, rather than 
> putting it directly in tm.texi.in.  (So you'd put the @hook in tm.texi.in, 
> but not the main body of the documentation for the hook.)

Changed.

> A default of ".rodata" instead of NULL would seem to simplify the rest of 
> the patch.

Changed.

>> -      char name[30];
>> +      char name[80];
> 
> There seems to be some undocumented requirement on the maximum length of 
> the string named by the hook, to avoid buffer overruns with these 
> fixed-size buffers.  Consider using alloca (or asprintf to avoid needing 
> to work out manually how much to add to the length of the string, but then 
> you need to free things before returning) to avoid such an undocumented 
> bound.

Changed.

New version below; tests running now on i686-linux after a bootstrap.


Bernd

Attachment: mrp.diff
Description: Text document