This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix DWARF so types with subprogram definitions don't get moved to type unit (issue4433068)

From: Jason Merrill <jason at redhat dot com>
To: ccoutant at google dot com, jason at redhat dot com, jason dot merrill at gmail dot com, gcc-patches at gcc dot gnu dot org, reply at codereview dot appspotmail dot com
Date: Thu, 05 May 2011 17:42:31 -0400
Subject: Re: [patch] Fix DWARF so types with subprogram definitions don't get moved to type unit (issue4433068)
References: <20cf303a33f5e6788d04a28e1e1a@google.com>

On 05/05/2011 05:33 PM, ccoutant@google.com wrote:

I couldn't convince myself that a subprogram definition inside a type
declaration would never happen, so I took the defensive approach. If
you're confident that it can't (or shouldn't) ever happen, then what if
I leave the predicate contains_subprogram_definition as is, remove the
call from the condition, and instead assert that it returns false just
before returning 1 from should_move_die_to_comdat?

Sounds good.

Jason

References:
- Re: [patch] Fix DWARF so types with subprogram definitions don't get moved to type unit (issue4433068)
  - From: ccoutant

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]