This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: (build) Patch to fix cp/cfns.gperf building issues
On Apr 23, 2011, "Nicola Pero" <nicola.pero@meta-innovation.com> wrote:
> Ok to commit ?
Yeah, thanks.
> Index: ChangeLog
> +2011-04-22 Nicola Pero <nicola.pero@meta-innovation.com>
> +
> + * Makefile.in (ENABLE_MAINTAINER_RULES): New.
> +
> Index: cp/ChangeLog
> +2011-04-23 Nicola Pero <nicola.pero@meta-innovation.com>,
> + Mike Stump <mikestump@comcast.net>
> +
> + * Make-lang.in ($(srcdir)/cp/cfns.h): Enable the dependency only
> + in maintainer mode. Use the --output-file option of gperf instead
> + of > to prevent creating an empty cp/cfns.h when gperf is not
> + available.
> +
-pedantic review: how about outputting to a temporary file (say
cp/cfns.hT) and only renaming to the intended name on success, so that,
if gperf crashes or we reboot part-way through it, we don't end up with
a partially-generated file that will seem to be up to date?
--
Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/ FSF Latin America board member
Free Software Evangelist Red Hat Brazil Compiler Engineer