This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)


Mike,

[Could you please configure your mail client to break lines?  It's hard
to reply to messages all on a single line.  Thanks.]

> On Apr 19, 2011, at 11:12 AM, Rainer Orth wrote:
>> I've had a closer look now and think it's possible (and desirable) to
>> define HAVE_GAS_HIDDEN for Darwin, too.
>
> But, they don't have the same thing, therefore, either, you loose out on the meaning, or, you must have yet another test that means the rest.  In your email, you don't state that you want to loose out, nor do you state that you want an additional test, so, I am left wondering what you want.  I'd say, forge ahead, the worst you can do is break everything...  You'll either be careful and not break anything, or you will and someone will pipe up with the bit you broke.  I'd like to think we have enough tests in the testsuite to ensure you can't silently break the major pieces.

True, Darwin only supports a subset of the whole set of visibilites
supported by ELF targets, and even amoung ELF targets there are
differences.  The testsuite already deals with that alright, and the
vast majority of uses inside the compiler proper only use
VISIBILITY_(DEFAULT|HIDDEN|INTERNAL) that are supported by Darwin, too.

I plan both to check if there are problematic cases that assume more
from the target, and of course will rely on a bootstrap and regtest to
detect problems.

It's probably best to wait for the tested patch and judge from there.
If all else fails, one could sprinkle TARGET_MACHO over the affected
places, but that can only be a very last resort IMO.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]