This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v3] Re: avoid useless if-before-free tests
- From: Janne Blomqvist <blomqvist dot janne at gmail dot com>
- To: Jim Meyering <jim at meyering dot net>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
- Date: Mon, 18 Apr 2011 19:06:57 +0300
- Subject: Re: [PATCH v3] Re: avoid useless if-before-free tests
- References: <87zkp9zmq0.fsf@rho.meyering.net> <Pine.LNX.4.64.1103051908320.3878@digraph.polyomino.org.uk> <877hc9r8w6.fsf_-_@rho.meyering.net> <877hc9pkhp.fsf_-_@rho.meyering.net> <AANLkTimAfkfmmfxrNp4w_wD2rGiQ7x07esgtVDT_-8Cj@mail.gmail.com> <87ei5w8nt7.fsf@rho.meyering.net> <BANLkTi=Dw4Qwh0cr1hfscpKYpkQp0SaVkg@mail.gmail.com> <87ei4z7g2i.fsf@rho.meyering.net>
On Mon, Apr 18, 2011 at 18:08, Jim Meyering <jim@meyering.net> wrote:
> I've rebased and divided/reordered these changes as you suggested.
> Here are the fortran parts. ÂI'll post the other parts separately.
> Parts 1 and 3 are manual. ÂPart 2 is the big mechanical change with
> two manual adjustments:
>
> Â[PATCH 1/3] gfortran: remove cpp definition of free, ...
> Â[PATCH 2/3] convert each use of gfc_free (p) to free (p)
> Â[PATCH 3/3] gfortran: remove now-unused definition of gfc_free
Thanks. The patches themselves are ok, however the changelog parts
should conform to the layout used otherwise for changelog entries (GNU
ChangeLog format, IIRC). The commit logs themselves that you have now
used are, IMHO, more informative and contain less clutter, but alas..
Note that it's recommended and usually easiest to provide changelog
entries separately, not as diffs from the ChangeLog file. Then when
you commit you insert the entry. This avoids the problem of frequent
conflicts as the top of the changelog file changes for every commit.
(Why we, in the age of non-sucky version control, persist in keeping
manual changelog files is beyond me..)
With these changes, Ok for trunk. Thanks a lot for the contribution!
--
Janne Blomqvist