This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: proposed patch -- remove superflous lines
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Axel Freyn <axel-freyn at gmx dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 12 Apr 2011 16:32:45 +0000 (UTC)
- Subject: Re: proposed patch -- remove superflous lines
- References: <20110412141455.GT3858@axel>
On Tue, 12 Apr 2011, Axel Freyn wrote:
> Hi,
>
> as that's the first time I propose a patch for gcc: sorry for all formal
> mistakes (and please tell me what I should do differently ...)
>
> Those lines were introduced in svn:164531 (22. Sep. 2010), but in
> svn:166534 (10. Nov. 2010) the part which could change "argv_copied"
> was removed. As no-where in the trunk "argv_copied" appears, I'm quite
> sure those three lines could be removed.
Thanks. I've committed the patch. The main thing missing was a ChangeLog
entry; I used:
2011-04-12 Axel Freyn <axel-freyn@gmx.de>
* opts-common.c (decode_cmdline_options_to_array): Remove variable
argv_copied.
See <http://gcc.gnu.org/contribute.html> for full instructions. What's
applicable depends on the individual patch (for example, it doesn't make
sense to add a testcase for a patch like this that doesn't change the
compiler's behavior).
--
Joseph S. Myers
joseph@codesourcery.com