This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] -E/-save-temps locus fix (PR preprocessor/48248)
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Tom Tromey <tromey at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 29 Mar 2011 16:55:46 +0000 (UTC)
- Subject: Re: [PATCH] -E/-save-temps locus fix (PR preprocessor/48248)
- References: <20110329155958.GM18914@tyan-ft48-01.lab.bos.redhat.com>
On Tue, 29 Mar 2011, Jakub Jelinek wrote:
> Hi!
>
> My PR41445 fix apparently sometimes results in wrong locus.
> The problem is if we switch temporarily to a locus of some token
> from a header file (PR41445 was fixing a problem where -save-temps
> behaved differently then normal compilation as locuses were different)
> and the line in the header file is within 8 lines of the line in the
> current source file, maybe_print_line optimizes and will emit
> newlines instead of emitting # X "file"... line.
> The optimization should be done only if it is the same file though.
>
> Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux,
> ok for trunk/4.6?
OK.
--
Joseph S. Myers
joseph@codesourcery.com