This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, libgfortran] Bug 48030 - Implement read_x using fbuf_getc
- From: Janne Blomqvist <blomqvist dot janne at gmail dot com>
- To: Jerry DeLisle <jvdelisle at frontier dot com>
- Cc: gfortran <fortran at gcc dot gnu dot org>, gcc patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 22 Mar 2011 15:19:40 +0200
- Subject: Re: [patch, libgfortran] Bug 48030 - Implement read_x using fbuf_getc
- References: <4D8586AA.80500@frontier.com> <4D87F82F.90909@frontier.com>
On Tue, Mar 22, 2011 at 03:15, Jerry DeLisle <jvdelisle@frontier.com> wrote:
> Ping
>
> On 03/19/2011 09:46 PM, Jerry DeLisle wrote:
>>
>> Hi,
>>
>> The attached patch re-implements read_x using fbuf_getc. Self explanatory.
I suspect this doesn't actually fix the issue with reading from a pipe
before we have consumed all existing data in all cases, as in line
1212 fbuf_read() is still called. Thus I think we should fold this EOF
detection in line 1212-1228 into the main while loop similar to
transfer.c:read_sf(). Or am I missing something?
--
Janne Blomqvist