This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 02/18] enforce TREE_CHAIN and TREE_TYPE accesses


On Sat, Mar 12, 2011 at 01:08:23PM +0100, Eric Botcazou wrote:
> > gcc/ada/
> > 	* gcc-interface/ada-tree.h (union lang_tree_node): Check for
> > 	TS_COMMON before calling TREE_CHAIN.
> > 	* gcc-interface/misc.c (gnat_init_ts): New function.
> > 	(LANG_HOOKS_INIT_TS): Define.
> 
> I presume that PLUS_NOMOD_EXPR, MINUS_NOMOD_EXPR and ATTR_ADDR_EXPR need not 
> be marked in gnat_init_ts?  If so, please add a single comment to that effect 
> in the function and reorder the lines to match the order in ada-tree.def.

Well, they never have their TREE_TYPE taken during bootstrap and test,
at least...

You're right, though; they should probably be marked as such for
completeness.  OK to commit with those additions and reordering as above
sight unseen, or would you like to see the patch?

-Nathan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]