This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch i386,c,c++]: PR/12171 - calling convention omitted in error message
- From: Kai Tietz <ktietz70 at googlemail dot com>
- To: Jason Merrill <jason at redhat dot com>
- Cc: Gabriel Dos Reis <gdr at integrable-solutions dot net>, "Joseph S. Myers" <joseph at codesourcery dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Henderson <rth at redhat dot com>
- Date: Thu, 17 Mar 2011 17:23:51 +0100
- Subject: Re: [patch i386,c,c++]: PR/12171 - calling convention omitted in error message
- References: <AANLkTi=WqqzyfhVYYhsz96jNjQqeALq+LjTordVs90Ew@mail.gmail.com> <AANLkTimRHU5u6oZ3n9-8LuierC8V-ECqGx+kENmRHvJY@mail.gmail.com> <Pine.LNX.4.64.1012231219080.14174@digraph.polyomino.org.uk> <AANLkTinaZSNCOOjk4rU5M8FTn-BAt84VyzNCZoSrp6OA@mail.gmail.com> <AANLkTimxao3i4x8xj2T=H2o+mxhz+_CParivB7OHsndE@mail.gmail.com> <4D239ECC.7020604@redhat.com> <AANLkTimKVpNA9GTL=MCKBTMbEbUmEi8Hcs=sUT4L5z-p@mail.gmail.com> <4D822ACE.6020204@redhat.com> <AANLkTi=XO8jT7qEP263NYM_K2d70TsMQEPdR0mTSRkk+@mail.gmail.com> <4D82340D.5030203@redhat.com>
2011/3/17 Jason Merrill <jason@redhat.com>:
> On 03/17/2011 12:08 PM, Kai Tietz wrote:
>>
>> I thought to use here instead of on_diagnostic (which is IMHO fine too
>> as it indicates for now only that attribute shall be displayed on
>> diagnostics) "affects_abi". I think it makes sense to keep that name
>> as short as possible.
>
> Hmm, type compatibility is higher level than the ABI; it affects whether two
> declarations are considered to be the same. ?I think clarity is more
> important than a short name for something that shouldn't be used in that
> many places. ?I'd prefer "affects_type_identity".
I will update the patch and using this name
> And does changing comp_type_attributes to check it make sense to you?
Well, in general it would, but not all of those affecting type
identity in 64-bit vs. 32-bit case. Most of them affect type identity
only in 32-bit, but not for 64-bit )at least so for amd64/x86). So I
don't think we will profit here much.
Kai