This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Updated DW_OP_GNU_entry_value/DW_TAG_GNU_call_site patch

On Wed, Mar 16, 2011 at 4:28 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Wed, Mar 16, 2011 at 03:38:25PM -0700, H.J. Lu wrote:
>
> IMNSHO you really should reconsider using Pmode != ptr_mode for your port.

Someone can give it a try.

My main concern is the x32 process is running in 64bit mode.  Its
stack operation is 64bit.

> That said, the patch looks good to me, though I can't approve it.

Richard, Jason, is this patch OK with PR debug/48160 in the ChangeLog entry.?

>> diff --git a/gcc/ChangeLog.x32 b/gcc/ChangeLog.x32
>> index 764e3de..45db256 100644
>> --- a/gcc/ChangeLog.x32
>> +++ b/gcc/ChangeLog.x32
>> @@ -1,5 +1,9 @@
>> ?2011-03-16 ?H.J. Lu ?<hongjiu.lu@intel.com>
>>
>> + ? ? * var-tracking.c (prepare_call_arguments): Check SUBREG.
>
> Just mention PR debug/48160 in the ChangeLog entry...
>

Done.

Thanks.

-- 
H.J.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]