This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix hpux10 string to real conversion defficiences


On 03/12/2011 08:01 AM, John David Anglin wrote:
I have reviewed the patch and FX'scomments. So far so good.

I may have missed something in the thread, but are you planning
modifications to the functions that call convert_real to allow the nan
or inf strings to be passed to convert_real?

The read_real function is already handling this for namelist and list
directed reads and I believe it is not needed by convert_real for those
functions.

For formatted reads, read_f will error out on a nan or inf during the
read before calling convert_real.

Here is take three. The configure checks are eliminated and a new function, convert_infnan, is added to convert INFs and NANs using builtins. It relies to some extent on the processing done by read_f, parse_real and read_real.

Tested on hppa1.1-hp-hpux10.20, hppa2.0w-hp-hpux11.11, hppa64-hp-hpux11.11
and i686-apple-darwin9 with no observed regressions.

Ok?

This is very intrusive this close to 4.6 release. With that said, I would like to regression test a few more different platforms. I will start on mine here shortly.


Regards,

Jerry


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]