This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR 47862: Fix caller-save vector spill on PowerPC
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: Pat Haugen <pthaugen at linux dot vnet dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 7 Mar 2011 11:32:45 -0500
- Subject: Re: [PATCH] PR 47862: Fix caller-save vector spill on PowerPC
- References: <4D712A10.1050608@linux.vnet.ibm.com>
On Fri, Mar 4, 2011 at 1:06 PM, Pat Haugen <pthaugen@linux.vnet.ibm.com> wrote:
> Fix subject PR by defining HARD_REGNO_CALLER_SAVE_MODE to return V2DFmode
> for vectors in FP regs.
>
> Bootstrap/regtest on powerpc with no new failures. Ok for trunk and 4.5
> (after successful 4.5 bootstrap/regtest)?
>
> -Pat
>
>
> 2011-03-04 ?Pat Haugen <pthaugen@us.ibm.com>
>
> ? ? ? ?* config/rs6000/rs6000.h (HARD_REGNO_CALLER_SAVE_MODE): Define.
> ? ? ? ?* config/rs6000/e500.h (HARD_REGNO_CALLER_SAVE_MODE): Undefine
> ? ? ? ? before definition.
>
> testsuite/ChangeLog
> ? ? ? ?* testsuite/gcc.target/powerpc/pr47862.c: New.
This patch is okay.
As I mentioned on IRC, I am a little concerned that the macro returns
V2DFmode instead of V2DImode (normal FPRs use DImode, not DFmode), but
no one seems to be aware of any problems that will cause.
Thanks, David