This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.

From: Tom Tromey <tromey at redhat dot com>
To: Michael Snyder <msnyder at vmware dot com>
Cc: Tristan Gingold <gingold at adacore dot com>, Jakub Jelinek <jakub at redhat dot com>, "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>, "gcc-patches\ at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Fri, 04 Mar 2011 11:18:48 -0700
Subject: Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.
References: <4D70061C.10904@vmware.com> <20110303213008.GY30899@tyan-ft48-01.lab.bos.redhat.com> <4D700F5D.2030109@vmware.com> <807E3430-F4F7-464D-8E8A-527A86BA3D88@adacore.com> <4D712A5F.1040307__35010.4677411311$1299262072$gmane$org@vmware.com>

>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:

Michael> Are you sure?  There is a path to "goto unknown" from before the
Michael> call to the alloc function.  It might actually be null.  Some
Michael> versions of 'free' don't like that.

This isn't an issue with free any more.  Jim Meyering did some research
into it a while ago and fixed a number of popular free software projects
to remove the useless test.  Here's a page with some interesting data:

http://www.winehq.org/pipermail/wine-patches/2006-October/031544.html

Tom

Follow-Ups:
- Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.
  - From: Michael Snyder

References:
- libiberty/cplus-dem.c, ada-demangle: plug memory leak.
  - From: Michael Snyder
- Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.
  - From: Jakub Jelinek
- Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.
  - From: Michael Snyder
- Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.
  - From: Tristan Gingold

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]