This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: ObjC/ObjC++: Fix property encoding on Apple


On Tue, Mar 01, 2011 at 02:50:47PM +0100, Nicola Pero wrote:
> 
> >> Can you replace that test with this one and let me know how it goes ? :-)
> >
> > Nicola,
> >    The file you attached isn't a replacement property-encoding-1.m file.
> > I manually changed the lines to + to remove those and deleted the lines
> > with - assuming it was a quasi patch. The resulting file still fails the
> > test under current gcc trunk as...
> 
> Thanks Jack,
> 
> on Sat, 26 Feb, 2011 at 16:46, you had responded to the same email saying --
> 
> > Nicola,
> >   I can confirm that your replacement property-encoding-1.m eliminates the
> > failures at -m64 on x86_64-apple-darwin10. Thanks for fixing that.
> 
> Can you just confirm which of the two is the case ? :-)
> 
> I was preparing to commit the revised testcase, but if it's still broken,
> I obviously won't ;-)
> 
> Let me know, and thanks for your help :-)
> 
> Thanks

Nicola,
   Actually I am confused now. This testcase fix is regarding...

http://gcc.gnu.org/ml/gcc-patches/2011-02/msg01621.html
http://gcc.gnu.org/ml/gcc-patches/2011-02/msg01627.html

right? I just cleaned my tree and tried to reapply http://gcc.gnu.org/ml/gcc-patches/2011-02/txt00134.txt.
This produces...

patching file gcc/objc/objc-act.c
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 

Is this the intended change in the original patch?
          Jack


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]