This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PR debug/47106] account used vars only once
> Now onto ipa-inline-stack-growth-referenced-vars-pr47106.patch
>
> it looks ok apart from the new pass_inlinable stuff, that at least sounds
> odd and I'd want Honza to have a look here. The testcase you say
It is because early inliner depends on toporder to properly place always_inline functions, right?
I guess it is sane solution. We might try to avoid recomputing inlinable in inline_parameters
done just before early_inline pass as we have nothing that should change inlinablity.
But in longer run we might want to add some cleanups before early inlining there, so I guess it is
easier to not worry here.
> the patch breaks otherwise redefines a _static_ inline function, so
> I'd say it's invalid anyway. I also wonder why computing
> ->inlineable should have any effect on that testcase ...
I don't see the testcase redefining anything, it seems to me that toporder is now getting wrong.
I will try to look into this tomorrow.
If this is solved, the patch is OK.
Honza