This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add some forgotten exports to libgfortran/gfortran.map (PR libfortran/47757)


On Wed, Feb 16, 2011 at 08:18:39PM +0200, Janne Blomqvist wrote:
> On Wed, Feb 16, 2011 at 19:23, Jakub Jelinek <jakub@redhat.com> wrote:
> > On Wed, Feb 16, 2011 at 06:10:12PM +0100, Tobias Burnus wrote:
> >> On 02/16/2011 02:51 PM, Jakub Jelinek wrote:
> >> >As the testcases below show, some exports from libgfortran.so
> >> >were forgotten on targets with symbol versioning.
> >> >This patch fixes it, bootstrapped/regtested on x86_64-linux and i686-linux,
> >> >ok for trunk?
> >>
> >> OK. Thanks for the patch. I think we should do something similar
> >> before every new release.
> >
> > Agreed. ?Anyway, there are other issues:
> > 1) for __float128 using targets, lots of new symbols appeared even in older
> > ? GFORTRAN_1.0 etc. versions, ideally they would go to GFORTRAN_1.4
> > ? if they have been added on those targets for 4.6 (you'd probably need
> > ? to preprocess gfortran.map for this)
> > 2) I see quite many PLT slots for _gfortran_* functions in libgfortran.so.3,
> > ? while some of them may be from Fortran sources and harder to avoid,
> > ? perhaps a bunch of new iexport_proto's are needed
> 
> Would it make sense to compile libgfortran with -fvisibility=hidden?

It wouldn't, it would just completely break it.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]