Re: Fix PR tree-optimization/46494

[Richard Guenther <richard dot guenther at gmail dot com>]

On Mon, Feb 14, 2011 at 11:36 AM, Eric Botcazou <ebotcazou@adacore.com> wrote:
> Hi,
>
> this fixes an assertion in verify_flow_info with yet another fancy combination
> of options. ?As diagnosed by Jakub, loop_optimizer_finalize prematurely calls
> verify_flow_info before the TODO_cleanup_cfg of VRP.
>
> The patch removes the call to verify_flow_info from loop_optimizer_finalize
> and instead adds TODO_verify_flow to the appropriate passes. ?The rationale
> is that some passes just do:
>
> ?loop_optimizer_init
>
> ?/* some read-only analysis */
>
> ?loop_optimizer_finalize
>
> so returning a TODO from loop_optimizer_finalize seems overkill; for them, the
> patch doesn't add the TODO_verify_flow either; this gets rid of the ia64 hack
> in the process because all involved passes are run before RA now.
>
> Tested on i586-suse-linux, OK for the mainline?

Ok.

Thanks,
Richard.

>
> 2011-02-14 ?Eric Botcazou ?<ebotcazou@adacore.com>
>
> ? ? ? ?PR tree-optimization/46494
> ? ? ? ?* loop-unroll.c (split_edge_and_insert): Adjust comment.
> ? ? ? ?* loop-init.c (loop_optimizer_finalize): Do not call verify_flow_info.
> ? ? ? ?(pass_rtl_loop_done): Add TODO_verify_flow.
> ? ? ? ?* fwprop.c (pass_rtl_fwprop): Likewise.
> ? ? ? ?* modulo-sched.c (pass_sms): Likewise.
> ? ? ? ?* tree-ssa-dom.c (pass_dominator): Likewise.
> ? ? ? ?* tree-ssa-loop-ch.c (pass_ch): Likewise.
> ? ? ? ?* tree-ssa-loop.c (pass_complete_unrolli): Likewise.
> ? ? ? ?(pass_tree_loop_done): Likewise.
> ? ? ? ?* tree-ssa-pre.c (execute_pre): Likewise.
> ? ? ? ?* tree-ssa-reassoc.c (pass_reassoc): Likewise.
> ? ? ? ?* tree-ssa-sink.c (pass_sink_code): Likewise.
> ? ? ? ?* tree-vrp.c (pass_vrp): Likewise.
>
>
> 2011-02-14 ?Eric Botcazou ?<ebotcazou@adacore.com>
>
> ? ? ? ?* gcc.dg/pr46494.c: New test.
>
>
> --
> Eric Botcazou
>