This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, libgfortran] PR47667 I/O for reals: READ waits for input after "i" and "n"


On 02/11/2011 11:27 PM, Janne Blomqvist wrote:
On Sat, Feb 12, 2011 at 01:48, Jerry DeLisle<jvdelisle@frontier.com> wrote:
Hi,

The attached patch was regression tested x86-64. This prevents calling
eat_line and waiting for the next line.

We don't really have a wat to do a test case.

OK for trunk?

Ok.


As a curiosity, shouldn't eat_line() effectively be a no-op if the
current character is "\n"?


Yes, and a similar problem exists with logical and '.', integer and '+' and '-', and complex and '('.


We could pass the current character into eat_line, but I would have to modify code everywhere it is used. Another option would be to put c inside the dtp structure, and then test it in eat_line. That is also quite intrusive.

Since we have this same if block for all the different types I think i will just modify by using the same else if (c != '\n') in the specific places.

I will resubmit the patch with those cases.

Jerru


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]