This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch,google] Auto-detect suitable default behaviour for prefix canonicalization
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Simon Baldwin <simonb at google dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 8 Feb 2011 18:09:31 +0000 (UTC)
- Subject: Re: [patch,google] Auto-detect suitable default behaviour for prefix canonicalization
- References: <20110207170518.1FCE71C686E@hpgntab-ubiq73.eem.corp.google.com>
On Mon, 7 Feb 2011, Simon Baldwin wrote:
> + char *search_prefix = make_relative_prefix (decoded_options[0].arg,
> + standard_bindir_prefix,
> + standard_exec_prefix);
> + if (search_prefix)
> + {
> + char *search = concat (search_prefix, spec_machine, NULL);
> + if (access (search, R_OK) == 0)
> + get_relative_prefix = make_relative_prefix;
Are you sure this will be present in a native installation? As I
understand it you're looking for $exec_prefix/$target_noncanonical, and I
don't see that in my native installs.
In general the new option seems safer than the autodetection; certainly I
don't think the autodetection is safe for 4.6 at this stage. So it may be
useful to split this into one patch for the new option, and then a
separate follow-up patch to autodetect things.
--
Joseph S. Myers
joseph@codesourcery.com