This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [ARM, RFC] Support unaligned access for modern ARM processors
- From: Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>
- To: Jie Zhang <jie at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 27 Jan 2011 02:24:43 +0000
- Subject: Re: [ARM, RFC] Support unaligned access for modern ARM processors
- References: <4D19D3BD.4010507@codesourcery.com>
Hi Jie,
>
> Any comments are welcome.
I can't approve or reject your patch and I haven't yet finished
reading your patch in its entirety but one of the comments I have
straight up is about the lack of testcases for this. One of the
reasons that I would like to see this added is because to a large
degree the patch is predicated on MEM_ALIGN information being up to
date. Thus it might be worth while adding testcases to make sure we
generate ldrd's when we know memory addresses are aligned and we keep
doing the right thing in the right places.
Another minor part of your patch that I'm not sure I totally like is
the part where you define output_asm_insn as a macro just across a
function. I'm not sure I like that style of coding especially because
it confuses a standard function name output_asm_insn with something
else.
cheers
Ramana
>
>
> Regards,
> --
> Jie Zhang
>
>