Re: [google] Add --with-native-system-header-dir to specify the location of /usr/include

[Simon Baldwin <simonb at google dot com>]

On 26 January 2011 00:12, Gerald Pfeifer <gerald@pfeifer.com> wrote:
>
> On Tue, 25 Jan 2011, Simon Baldwin wrote:
> > Index: gcc/doc/install.texi
> > ===================================================================
> > +If you specify the @option{--with-native-system-header-dir} option
> > +then the compiler will search that directory within @var{dir} for
> > +native system headers rather than the default @file{/usr/include}.
>
> I am wondering, should this be
> ?@option{--with-native-system-header-dir=@var{dir}}
> ? ?Otherwise, where is @var{dir} introduced?
>
> Also, in the documentation of --with-native-system-header-dir= you
> use dirname instead of dir which indeed seems to be common practice.

Thanks for the note.

install.texi is itself internally inconsistent around @var{dir} and
@var{dirname}, and uses them interchangeably, with @var{dirname} as
the most common choice.? From trunk at r169283:

? $ grep '^@item.*=@var{dir}$' doc/install.texi | wc -l
? 5
? $ grep '^@item.*=@var{dirname}$' doc/install.texi | wc -l
? 17

The new --with-native-system-header-dir= documentation section
directly follows "@item --with-local-prefix=@var{dirname}", and uses
@{dirname} for local consistency.

The two places where --with-native-system-header-dir referred to by
other options are both in @item...=@var{dir} sections.? In these, I've
updated the references to it to append =@var{dirname}, to be both
consistent with the main --with-native-system-header-dir documentation
section and also to differentiate from the @var{dir} used by the
enclosing section (here the dir/dirname difference is an advantage!).

Patch change detail:

$ diff ../37499.patch.old ../37499.patch
49,50c49,50
< +If you specify the @option{--with-native-system-header-dir} option
< +then the compiler will search that directory within @var{dir} for
---
> +If you specify the @option{--with-native-system-header-dir=@var{dirname}}
> +option then the compiler will search that directory within @var{dirname} for
60,61c60,61
< +If you specify the @option{--with-native-system-header-dir} option
< +then the compiler will search that directory within @var{dir} for
---
> +If you specify the @option{--with-native-system-header-dir=@var{dirname}}
> +option then the compiler will search that directory within @var{dirname} for

--
Google UK Limited | Registered Office: Belgrave House, 76 Buckingham
Palace Road, London SW1W 9TQ | Registered in England Number: 3977902