This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PR tree-optimization/47190: ICE on weakref missing alias info
On Tue, 25 Jan 2011, Jan Hubicka wrote:
> > > Well, process_function_and_variable_attributes was invented to finalize attributes
> > > that can not be handled well at parsing time because of decl merging issues.
> > > (we orginally tried to handle the attributes processed there in FE too and had
> > > funny bugs)
> > >
> > > You are concerned that the error is too late?
> >
> > Yes. It also doesn't "fit".
> >
> > I'd rather do it when first analyzing the compilation unit, maybe
> > when we build the cgraph and references?
>
> Well, when I was fixing the issues with externally visible attributes, I also
> decided it should go to first place when we analyze compilation unit and it is
> where process_function_and_variable_attributes is called. See
> cgraph_analyze_functions.
> It is done just before cgraph construction and outputs other warnings too.
Hmm, ok. I guess your original patch is ok then.
Thanks for bearing with me ;)
Richard.