This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch java]: Intialize va_list_type_node to avoid segfault for x86_64 targets in respect for alignment
On Mon, Jan 17, 2011 at 07:28:13AM -0700, Tom Tromey wrote:
> >>>>> "Richard" == Richard Guenther <richard.guenther@gmail.com> writes:
>
> Richard> Indeed. Please either revert the full series or work towards
> Richard> using build_common_tree_nodes.
>
> It seems to me that his current patches remove some crashes.
> Presumably they can't affect correctness since those nodes are never
> used or generated by the java front end in the first place.
> So, I think reverting them is too strong.
The crashes were just on i?86 AFAIK, and only because the backend (IMHO
incorrectly) assumed va_list_type_node is always non-NULL. I think
languages that don't have va_list type nor support va_* macros shouldn't be
forced to create such type.
> I agree that java probably should use the common tree-building
> infrastructure. ISTR looking at this once though and deciding it was
> hard.
I'd say that is clearly stage1 material though, not stage4.
The patch caused so many regressions that IMHO at least for stage4 reverting
it is the only sane approach.
Jakub