Re: [patch java]: Intialize va_list_type_node to avoid segfault for x86_64 targets in respect for alignment

[Kai Tietz <ktietz70 at googlemail dot com>]

2011/1/12 Richard Guenther <richard.guenther@gmail.com>:
> On Tue, Jan 11, 2011 at 9:38 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> Kai Tietz <ktietz70@googlemail.com> writes:
>>
>>> 2011/1/11 Andreas Schwab <schwab@linux-m68k.org>:
>>>> Kai Tietz <ktietz70@googlemail.com> writes:
>>>>
>>>>> Andreas, did this patch fixed rs6000 java bootstrap for you?
>>>>
>>>> The discrepancies with TYPE_STRING_FLAG and char_type_node remain. ?I
>>>> don't know what kind of hidden effect that will have.
>>>>
>>>> Andreas.
>>>
>>> I don't know if there are side-effects, or not. I just know that this
>>> type wasn't set before, so it seems not to be used before.
>>
>> But it is used now, so care must be taken. ?Especially the different
>> char_type_node is worrying.
>
> Indeed. ?Please either revert the full series or work towards
> using build_common_tree_nodes.
>
> Richard.
>
>> Andreas.

Well, as described in bug-report this missing va_list_type_node in
java's decl.c is a regression from 1999. I attaced a patch, which is
reverting it, but it is  a paper-patch. That char_type_node is used
within va_list_type_node of java's decl.c, shouldn't lead here to any
issues, as java FE didn't used that types before (as otherwise there
would be ICEs without that patch already), and now those types are
used just in va_list_type_node construction. The va_list types are
just used in comparison by some backends. Java doesn't operate with
va_list_type_node and you can't specify them within this language
AFAICS.


2011-01-16  Kai Tietz

	PR bootstrap/47215
	* decl.c (java_init_decl_processing): Remove
	va_list_type_node related type initializations.

2011-01-16  Kai Tietz

	PR bootstrap/47215
	* config/i386/i386.c (ix86_local_alignment): Handle
	case for va_list_type_node is nil.
	(ix86_canonical_va_list_type): Likewise.

Tested for x86_64-pc-linux-gnu and x86_64-w64-mingw32. Ok for apply?

Regards,
Kai

Attachment: pr47215.txt
Description: Text document