This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [14/25] Specs cleanup: MIPS -call_shared -non_shared
"Joseph S. Myers" <joseph@codesourcery.com> writes:
> On Fri, 14 Jan 2011, Richard Sandiford wrote:
>> "Joseph S. Myers" <joseph@codesourcery.com> writes:
>> > In addition to the specs mentioned in patch 13, various MIPS targets
>> > have specs passing -call_shared and -non_shared to the linker. While
>> > these options do exist with the GNU linker, there is nothing
>> > MIPS-specific about them and there should be nothing MIPS-specific
>> > about such options being accepted by the driver; the appropriate
>> > dependence is on the target operating system. Thus, this patch
>> > removes them also from specs for non-IRIX targets. OK to commit?
>>
>> I'm not sure this is a good idea. I'd agree with your logic if we
>> were starting from scratch, but I don't see the need to change from
>> historical precendent now.
>
> The immediate motivation is getting all options into .opt files so that
> the driver can (in 4.7) start rejecting options not known in a .opt file
> rather than accepting them if matched by some spec.
>
> While of course these options can be added to a .opt file or files (it's
> fairly harmless for a .opt file to list some options that are not in fact
> accepted by specs for all targets using that .opt file), there seems to be
> very little logic about which are accepted where. mips/linux64.h accepts
> both, mips/linux.h accepts neither, mips/mips.h accepts only -non_shared,
> mips/netbsd.h accepts only -call_shared - so there is no consistency of
> design even for MIPS targets here.
OK, that's a convincing argument. I hadn't realised that linux.h and
linux64.h did different things here. Since linux.h doesn't have them,
I agree there's very little to worry about.
I'll echo Eric's OK.
Richard