This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[libgo] Run gotest with $SHELL
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: gcc-patches at gcc dot gnu dot org
- Cc: Ian Lance Taylor <iant at google dot com>
- Date: Fri, 14 Jan 2011 17:24:41 +0100
- Subject: [libgo] Run gotest with $SHELL
Currently, testsuite/gotest is run with whatever /bin/sh on the given
system happens to be. When bootstrapping with Go on Solaris 10, /bin/sh
complains
/vol/gcc/src/hg/trunk/solaris/libgo/testsuite/gotest: LC_ALL=C: is not an identi
fier
/vol/gcc/src/hg/trunk/solaris/libgo/testsuite/gotest: syntax error at line 209:
`gofiles=$' unexpected
This can be avoided by running gotest with $SHELL explicitly, as the
following patch does.
Ok for mainline?
Rainer
2011-01-14 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
* Makefile.am (CHECK): Run gotest with $(SHELL).
* Makefile.in: Regenerate.
diff -r 6c184227ca86 libgo/Makefile.am
--- a/libgo/Makefile.am Fri Jan 14 10:25:46 2011 +0100
+++ b/libgo/Makefile.am Fri Jan 14 17:13:20 2011 +0100
@@ -1305,9 +1305,9 @@
prefix=`if test "$(@D)" = "regexp"; then echo regexp-test; else dirname $(@D); fi`; \
test "$${prefix}" != "." || prefix="$(@D)"; \
if test "$(use_dejagnu)" = "yes"; then \
- $(srcdir)/testsuite/gotest --dejagnu=yes --basedir=$(srcdir) --srcdir=$(srcdir)/go/$(@D) --prefix="libgo_$${prefix}" --pkgfiles="$(go_$(subst /,_,$(@D))_files)"; \
+ $(SHELL) $(srcdir)/testsuite/gotest --dejagnu=yes --basedir=$(srcdir) --srcdir=$(srcdir)/go/$(@D) --prefix="libgo_$${prefix}" --pkgfiles="$(go_$(subst /,_,$(@D))_files)"; \
else \
- if $(srcdir)/testsuite/gotest --basedir=$(srcdir) --srcdir=$(srcdir)/go/$(@D) --prefix="libgo_$${prefix}" --pkgfiles="$(go_$(subst /,_,$(@D))_files)" >>$@-log 2>&1; then \
+ if $(SHELL) $(srcdir)/testsuite/gotest --basedir=$(srcdir) --srcdir=$(srcdir)/go/$(@D) --prefix="libgo_$${prefix}" --pkgfiles="$(go_$(subst /,_,$(@D))_files)" >>$@-log 2>&1; then \
echo "PASS: $(@D)"; \
else \
echo "FAIL: $(@D)"; \
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University