This is the mail archive of the
mailing list for the GCC project.
Re: patch: Trivial 1% speed upof ObjC compiler by reusing existing hash
- From: Mike Stump <mikestump at comcast dot net>
- To: Nicola Pero <nicola dot pero at meta-innovation dot com>
- Cc: "gcc-patches at gnu dot org" <gcc-patches at gnu dot org>
- Date: Thu, 13 Jan 2011 16:56:42 -0800
- Subject: Re: patch: Trivial 1% speed upof ObjC compiler by reusing existing hash
- References: <email@example.com>
On Jan 13, 2011, at 3:32 PM, Nicola Pero wrote:
> This trivial patch speeds up the Objective-C compiler by about 1% percent by removing
> the objc-act.c-specific hash function and simply using the hash value already computed
> by the rest of the compiler for identifiers. :-)
> I know we are in stage 4 and optimizations are not for this stage, but the patch is so obvious to me, maybe it could go in.
> Ok to commit ?
When we hit stage1, Ok. For this stage, I just don't think it should go in. I'm happy to have a RM overrule me, if they choose.
Now, I might bend to rules for some types of work, like quality polishing of the new objc code... or finishing out the implementation if there are some rough corners that just weren't completely finished. Very important features, like, m64 darwin support, might also be worth the risk.