This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH: ARM] PR 45335 Use ldrd and strd to access two consecutive words
- From: Richard Guenther <richard dot guenther at gmail dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: Richard Earnshaw <rearnsha at arm dot com>, Nick Clifton <nickc at redhat dot com>, Carrot Wei <carrot at google dot com>, Paul Brook <paul at codesourcery dot com>, gcc-patches at gcc dot gnu dot org, ramana dot radhakrishnan at arm dot com
- Date: Wed, 12 Jan 2011 11:11:41 +0100
- Subject: Re: [PATCH: ARM] PR 45335 Use ldrd and strd to access two consecutive words
- References: <AANLkTim+nD_6m5PwDBkz0BVz1Ftr+DYyih17nXX5LMue@mail.gmail.com> <1283354531.25967.50.camel@e102346-lin.cambridge.arm.com> <AANLkTimrgAq8=-=mne6F5f4WJOv+x2N8RxxYeDMJGBAi@mail.gmail.com> <201010131201.18075.paul@codesourcery.com> <AANLkTi=obfc3R-sguDE4uaU_Ni+ciNz5gtPVKnG-JBVB@mail.gmail.com> <AANLkTinRP8nnpH3pf1tQQEGmf4jQBPDfC0nZsBE=PUwE@mail.gmail.com> <AANLkTik0xyadAWfpdX4h8E+1g4a9ExMrQjZ0uzwWukCR@mail.gmail.com> <AANLkTinsJxUc3H_naUR4cvYeioHim3dn4=BMscmiDokZ@mail.gmail.com> <AANLkTi=VYKUFBLhd==hLOx=xpPO8kGF7uu11A_-0hazv@mail.gmail.com> <AANLkTim0BRLUezvJ_U16jNunvvPR1Yn=cv2QdWwrxepQ@mail.gmail.com> <AANLkTi=rdaKqDmLppspFbPuVKdtuw-PiXF89+w3Jk6u=@mail.gmail.com> <4D2C66FB.9090100@redhat.com> <1294757346.14576.94.camel@e102346-lin.cambridge.arm.com> <AANLkTike6LqmitJz8itMkAahC=bg1h-p+EFbpuSpicHb@mail.gmail.com>
On Wed, Jan 12, 2011 at 6:23 AM, Ian Lance Taylor <iant@google.com> wrote:
> On Tue, Jan 11, 2011 at 6:49 AM, Richard Earnshaw <rearnsha@arm.com> wrote:
>>
>> On Tue, 2011-01-11 at 14:19 +0000, Nick Clifton wrote:
>>> Hi Carrot,
>>>
>>> >>>>>>> ChangeLog:
>>> >>>>>>> 2010-10-16 ?Wei Guozhi<carrot@google.com>
>>> >>>>>>>
>>> >>>>>>> ? ? ? ? PR target/45335
>>> >>>>>>> ? ? ? ? * gcc/config/arm/thumb2.md (thumb2_ldrd, thumb2_ldrd_reg1,
>>> >>>>>>> ? ? ? ? thumb2_ldrd_reg2 and peephole2): New insn pattern and related
>>> >>>>>>> ? ? ? ? peephole2.
>>> >>>>>>> ? ? ? ? (thumb2_strd, thumb2_strd_reg1, thumb2_strd_reg2 and peephole2):
>>> >>>>>>> ? ? ? ? New insn pattern and related peephole2.
>>> >>>>>>> ? ? ? ? * gcc/config/arm/arm.c (thumb2_legitimate_ldrd_p): New function.
>>> >>>>>>> ? ? ? ? (thumb2_check_ldrd_operands): New function.
>>> >>>>>>> ? ? ? ? (thumb2_prefer_ldmstm): New function.
>>> >>>>>>> ? ? ? ? * gcc/config/arm/arm-protos.h (thumb2_legitimate_ldrd_p): New prototype.
>>> >>>>>>> ? ? ? ? (thumb2_check_ldrd_operands): New prototype.
>>> >>>>>>> ? ? ? ? (thumb2_prefer_ldmstm): New prototype.
>>> >>>>>>> ? ? ? ? * gcc/config/arm/ldmstm.md (ldm2_ia, stm2_ia, ldm2_db, stm2_db):
>>> >>>>>>> ? ? ? ? Change the ldm/stm patterns with 2 words to ARM only.
>>>
>>> Approved - please apply.
>>>
>>
>> No, this is not yet ready. ?It certainly isn't ready to go in this late
>> in gcc-4.6, which is now in regression-only fixes stage.
>>
>> Sorry, I still think this needs more work, but I'm dashing off to yet
>> another meeting right now.
>
> Richard, I really have to object to this. ?Carrot proposed this patch
> before gcc went into stage 3, and has pinged it regularly, which by
> the rules as I understand them means that it can be accepted during
> stage 3 if the target maintainers agree.
Not specific to this issue, but we are in stage 4 now which means that
only fixes for regressions and documentation are allowed.
Patches that only affect non-primary/secondary targets
target maintainers may have more freedom. We also regularly
accepted non-regression wrong-code and rejects-valid patches
at this stage.
That's 2 cents from your release manager(s) (aka, "it was posted
during stageN < 3" isn't on its own a good enough reason to
not honor restrictions of stageN >= 3).
Richard.