This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch i386,c,c++]: PR/12171 - calling convention omitted in error message

On 01/01/2011 01:07 PM, Kai Tietz wrote: 
Well, as here no further agreement was found, I post here the
alternative suggested by Joseph. I am open-minded which approach will
be chosen. I just want to fix this long pending issue.
I split up this patch in two parts. The first simply extends the
struct attribute_spec by new member 'on_diagnostic' and extends the
the uses of this structure by this new field. This new member
specifies if the attribute shall be show on diagnostic output, or not.

This seems like a reasonable approach, but I'd prefer to describe/name the field as indicating that the attribute affects type compatibility (since that's why we want to see the attribute in diagnostics), and making the default comp_type_attributes use that information.

Jason

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]