This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix combiner with (set (pc) (pc)) jumps in undo_buf.other_insn (PR rtl-optimization/47157)

From: Paolo Bonzini <bonzini at gnu dot org>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Mon, 03 Jan 2011 17:05:43 +0100
Subject: Re: [PATCH] Fix combiner with (set (pc) (pc)) jumps in undo_buf.other_insn (PR rtl-optimization/47157)
References: <20110103143624.GD16156@tyan-ft48-01.lab.bos.redhat.com>

On 01/03/2011 03:36 PM, Jakub Jelinek wrote:

Hi!

If try_combine turns a JUMP_INSN into a noop move, it correctly calls
update_cfg_for_uncondjump on it and sets *new_direct_jump_p if the
noop move is in i3, but as shown on the testcase below, a jump can
be turned into a noop move also when adjusting the only CC user and in that
case we wouldn't do the necessary cfg adjustments.

Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for
trunk?

Looks good to me.

Paolo

References:
- [PATCH] Fix combiner with (set (pc) (pc)) jumps in undo_buf.other_insn (PR rtl-optimization/47157)
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]