This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Remove -combine support
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Richard Guenther <rguenther at suse dot de>
- Cc: Diego Novillo <dnovillo at google dot com>, gcc-patches at gcc dot gnu dot org, "Joseph S. Myers" <joseph at codesourcery dot com>, Raksit Ashok <raksit at google dot com>, Xinliang David Li <davidxl at google dot com>
- Date: Fri, 31 Dec 2010 12:29:20 -0800
- Subject: Re: [PATCH] Remove -combine support
- References: <alpine.LNX.2.00.1009161320440.28912@zhemvz.fhfr.qr> <AANLkTinbb1n5_Cz0deV59Dm_k19CSbTrM7pF0BYvzTSO@mail.gmail.com> <alpine.LNX.2.00.1009161540260.28912@zhemvz.fhfr.qr> <alpine.LNX.2.00.1009161642520.28912@zhemvz.fhfr.qr>
On Thu, Sep 16, 2010 at 7:43 AM, Richard Guenther <rguenther@suse.de> wrote:
> On Thu, 16 Sep 2010, Richard Guenther wrote:
>
>> On Thu, 16 Sep 2010, Diego Novillo wrote:
>>
>> > On Thu, Sep 16, 2010 at 07:23, Richard Guenther <rguenther@suse.de> wrote:
>> >
>> > > 2010-09-16 ?Richard Guenther ?<rguenther@suse.de>
>> > >
>> > > ? ? ? ?* common.opt (combine): Remove.
>> > > ? ? ? ?* gcc.c (struct compiler): Rename combinable field.
>> > > ? ? ? ?(default_compilers): Remove specs testing combine.
>> > > ? ? ? ?(option_map): Remove -combine.
>> > > ? ? ? ?(combine_inputs): Remove.
>> > > ? ? ? ?(display_help): Remove -combine.
>> > > ? ? ? ?(driver_handle_option): Remove OPT_combine handling.
>> >
>> > But LTO uses this for specifying multiple files, IIRC.
>>
>> Yeah - I noticed that. ?Bah. ?I'm working on a workaround for that,
>> and maybe my fourth try that is now testing will work ...
>
> Ok, so the following works.
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu, ok for trunk?
>
> Thanks,
> Richard.
>
> 2010-09-16 ?Richard Guenther ?<rguenther@suse.de>
>
> ? ? ? ?* common.opt (combine): Remove.
> ? ? ? ?* gcc.c (default_compilers): Remove specs testing combine.
> ? ? ? ?The C compilers no longer can combine.
> ? ? ? ?(option_map): Remove -combine.
> ? ? ? ?(combine_inputs): Remove.
> ? ? ? ?(display_help): Remove -combine.
> ? ? ? ?(driver_handle_option): Remove OPT_combine handling.
> ? ? ? ?(compile_input_file_p): Remove.
> ? ? ? ?(do_spec): Remove code concerning combine.
> ? ? ? ?(main): Likewise.
> ? ? ? ?* doc/invoke.texi: Remove traces of -combine.
> ? ? ? ?* lto-wrapper.c (run_gcc): Do not pass -combine to the compiler
> ? ? ? ?driver.
>
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47137
H.J.
This patch caused: