Re: [patch c,c++,i386]:PR/15774 - Conflicting function decls not diagnosed

[Gabriel Dos Reis <gdr at integrable-solutions dot net>]

On Wed, Dec 22, 2010 at 9:34 AM, Kai Tietz <ktietz70@googlemail.com> wrote:
> 2010/12/22 Gabriel Dos Reis <gdr@integrable-solutions.net>:
>> Any reason why is_first is of type `int' as opposed to `bool'?
>> rename pp_c_attributes_calling_convention to
>> pp_c_calling_convention_attributes.
>> You should probably modify cp/cxx-pretty-print.c too
>
> Well, I was first think here to implement logic different, but you are
> right, bool is better here. I adjusted patch. Also renamed function.
>
>> I really prefer we don't add pretty printing code to cp/error.c.
>> Rather, we should be deferring to the pretty printers in
>> cp/cxx-pretty-print.c. ?But, I suspect that is a battle for
>> another day.
>
> Well, I tried to do thing here first in cxx-pretty-print.c, but it
> doesn't had any effect for function pointers, so I did it just in
> error.c file. ?This seems to be a different battle for a different
> day.

The problem is we are going to have the same regression when
the cp/error.c to what it should be (as originally plan).
So, my suggestion to is to add similar code to cp/cxx-pretty-print.c.
Patch approved with that modification.