This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix remaining issues in PR46221/46674 wrt. unreachable alias analysis.

From: Richard Guenther <richard dot guenther at gmail dot com>
To: Dave Korn <dave dot korn dot cygwin at gmail dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Thu, 16 Dec 2010 13:35:31 +0100
Subject: Re: [PATCH] Fix remaining issues in PR46221/46674 wrt. unreachable alias analysis.
References: <4D09A03D.4070108@gmail.com> <AANLkTimsW+F=oRqoS_K8hLtH7Xq5xmLWbonoD-KHN-rR@mail.gmail.com> <4D0A0D23.40402@gmail.com>

On Thu, Dec 16, 2010 at 1:59 PM, Dave Korn <dave.korn.cygwin@gmail.com> wrote:
> On 16/12/2010 11:57, Richard Guenther wrote:
>
>> Is it only me or why does alias_set_t make me think of alias analysis?
>> Please instead use symbol_alias_set_*.
>
> ?Am confused by that asterisk. ?Did you mean "symbol_alias_set_t"?

Yes, and rename the helper functions too (that's the asterix).

Richard.

>> +static alias_set_t
>> +*alias_set_create (void)
>>
>> the * goes on the previous line. ?All functions need the usual
>> toplevel comments.
>>
>> Ok with those changes.
>
> ?Will do, thanks.
>
> ? ?cheers,
> ? ? ?DaveK
>
>

Follow-Ups:
- Re: [PATCH] Fix remaining issues in PR46221/46674 wrt. unreachable alias analysis.
  - From: Dave Korn

References:
- [PATCH] Fix remaining issues in PR46221/46674 wrt. unreachable alias analysis.
  - From: Dave Korn
- Re: [PATCH] Fix remaining issues in PR46221/46674 wrt. unreachable alias analysis.
  - From: Richard Guenther
- Re: [PATCH] Fix remaining issues in PR46221/46674 wrt. unreachable alias analysis.
  - From: Dave Korn

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]