This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [testsuite, ada, build] Allow for further differences in type output in run_acats


On Thu, 2010-12-02 at 19:35 +0100, Rainer Orth wrote:
> Ralf Wildenhues <Ralf.Wildenhues@gmx.de> writes:
> 
> > * Rainer Orth wrote on Wed, Dec 01, 2010 at 03:44:56PM CET:
> >> I've just noticed that the ACATS tests weren't run on IRIX 6.5 with
> >> /bin/ksh as CONFIG_SHELL.  It turned out that the which() shell function
> >> in ada/acats/run_acats still isn't robust enough.  type -p gnatchop
> >> would e.g. print
> >
> > Why don't you simply use the code which Autoconf provides for
> > AC_CHECK_PROG or AC_PATH_PROG?  Portable, stable, time-tested.
> 
> You'd probably have to ask the author of the original shell-based ACATS
> testsuite.  IMO the whole thing is so riddled with problems (both
> portability and functionality, like no multilib support and copying the
> whole testsuite into the build tree for every parallel invocation) that
> any time spent improving it in its current form is wasted ;-(
> 
> I see absolutely no reason to have a non-Dejagnu based testsuite in
> tree; this only creates integration problems of all sorts.  Given that
> we have the gnat.dg testsuite now, it shouldn't be too hard to extend
> that to ACATS.

Hi,

That was my first look but since no one ever responded to my dejagnu/GCC
questions at the time I ended up writing a simple shell script to run
ACATS, I'm happy to see dejagnu expert stepping in to fix this :). 

The only specific thing about ACATS is that it has support files that
need to be generated and some source compiled before compiling and
running any ACATS test. The ACATS test execution output is very regular
so it should be easy to determine test status as is done in the shell
script. There a few tests that need specific compiler flags but they're
also all explicitely listed in the script.

Sincerely,

Laurent




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]