This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Cleanup, use bitmap_set_range/bitmap_clear_range instead of bitmap_set_bit/bitmap_clear_bit loops.

From: Jeff Law <law at redhat dot com>
To: Anatoly Sokolov <aesok at post dot ru>
Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 10 Dec 2010 09:29:24 -0700
Subject: Re: [PATCH] Cleanup, use bitmap_set_range/bitmap_clear_range instead of bitmap_set_bit/bitmap_clear_bit loops.
References: <851240104.20101208214631@post.ru>

On 12/08/10 11:46, Anatoly Sokolov wrote:

Hi.

   This patch converts loops of bitmap_set_bit/bitmap_clear_bit in to
bitmap_set_range/bitmap_clear_range functions call.

   The patch has been bootstrapped on and regression tested on
x86_64-unknown-linux-gnu for c.

OK to install?

         * cfgcleanup.c (mark_effect): Use bitmap_set_range/bitmap_clear_range
         instead of loop. Use HARD_REGISTER_NUM_P predicate.
         * haifa-sched.c (setup_ref_regs): Ditto.
         * caller-save.c (add_used_regs_1): Ditto.
         * dse.c (look_for_hardregs): Ditto.
         * df-problems.c (df_simulate_one_insn_forwards): Ditto.
         * sched-rgn.c (check_live_1): Ditto.

This looks like a reasonable cleanup, but I can't see how this fixes any kind of bug, so it should be postponed until stage1 reopens. If you could attach it to the GCC 4.7 pending patches metabug that would help ensure it doens't get lost.

Thanks,
Jeff

References:
- [PATCH] Cleanup, use bitmap_set_range/bitmap_clear_range instead of bitmap_set_bit/bitmap_clear_bit loops.
  - From: Anatoly Sokolov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]