This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PING^2: resubmitted IRA improvement patches
- From: Vladimir Makarov <vmakarov at redhat dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: Kenneth Zadeck <zadeck at naturalbridge dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, "Bergner, Peter" <bergner at vnet dot ibm dot com>, Bernd Schmidt <bernds at codesourcery dot com>
- Date: Fri, 10 Dec 2010 11:23:39 -0500
- Subject: Re: PING^2: resubmitted IRA improvement patches
- References: <4CA4F868.2080009@redhat.com> <4CC1C4A7.7060205@naturalbridge.com> <4CC46430.4080304@redhat.com> <4CFD0B66.2050402@naturalbridge.com> <4D025095.10102@redhat.com>
On 12/10/2010 11:08 AM, Jeff Law wrote:
On 12/06/10 09:12, Kenneth Zadeck wrote:
sorry, for taking so long. i have been temporarily put on another
project.
i applied all of your patches to the trunk, and then reread all of
the ira files looking for parts that i did not understand. many of
them relate to the patches at hand but some are things that should
have been documented in earlier rounds that were just missed. When
these comments are properly addressed, you can check in your patches.
I think in addition to addressing documentation issues you've raised,
we need to decide if we want this patch in GCC 4.6 or if it should be
postponed until GCC 4.7.
The patch was clearly submitted early enough, but we're also further
out of stage1 than I'm comfortable just saying "go ahead and
install". My temptation is still to get the patch in given its
clear benefits, but I want others to have a chance to chime in.
I am pretty sure about the patch will not introduce new serious failures
which can not be fixed quick.
On the other hand, I'd expect some reports about performance or
compilation problems for some targets (I checked only x86/x86-64,
powerpc, and arm). And that probably can not be fixed soon.
It makes me think that submitting the patch at the beginning of stage #1
of gcc4.7 is probably a better idea. In this case, I'll have plenty
time to address these problems if we have them.