This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix rtx_equal_p and similar predicates on ASM_OPERANDS/ASM_INPUT (PR rtl-optimization/46865)


Jakub Jelinek wrote:
Actually, I think the issue is not just about comparing locators,
>  but rather: why do you need locator equality for
>  ASM_INPUT/ASM_OPERANDS to be equivalent? The checking of the other
Because then you regress in debug info quality, we emit the location
with .loc before the asm.  Though, for -O0 we hopefully don't perform
crossjumping and similar optimizations, and for -O1+ the code quality is
more important than debug info quality.

If we'd want to ignore it, the right fix wouldn't be your patch,
but just making that operand use 0 format instead of i and adjust
print-rtl.c etc.

I see your point.
However, to adjust the equivalence criteria depending on optimization level (as you suggested), changing to '0' format does not make it easier :) I would still suggest using code to achieve that.


CL


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]