This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PR45354] sel-sched: don't make EDGE_CROSSING edges fallthrough
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Alexander Monakov <amonakov at ispras dot ru>
- Cc: gcc-patches at gcc dot gnu dot org, "Vladimir N. Makarov" <vmakarov at redhat dot com>
- Date: Thu, 9 Dec 2010 11:29:06 -0800
- Subject: Re: [PR45354] sel-sched: don't make EDGE_CROSSING edges fallthrough
- References: <alpine.LNX.2.00.1011301607320.6883@monoid.intra.ispras.ru>
On Tue, Nov 30, 2010 at 5:31 AM, Alexander Monakov <amonakov@ispras.ru> wrote:
> Hi,
>
> We should not delete jumps if they cross hot/cold partition boundaries. ?The
> patch adds the corresponding check in bb_has_removable_jump_to_p (which is
> renamed from jump_leads_only_to_bb_p, making the name a bit closer to the
> purpose).
>
> Bootstrapped and regtested on ia64-linux, x86_64-linux. ?OK for trunk?
>
> 2010-11-30 ?Alexander Monakov ?<amonakov@ispras.ru>
>
> ? ? ? ?PR rtl-optimization/45354
> ? ? ? ?* sel-sched-ir.c (jump_leads_only_to_bb_p): Rename to ...
> ? ? ? ?(bb_has_removable_jump_to_p): This. ?Update all callers. Make static.
> ? ? ? ?Allow BBs ending with a conditional jump. ?Forbid EDGE_CROSSING jumps.
> ? ? ? ?* sel-sched-ir.h (jump_leads_only_to_bb_p): Delete prototype.
>
This caused:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46875
--
H.J.