This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH,c++] fix PR 45330, suggest alternatives for failed name lookups


On 12/6/2010 12:23 PM, Nathan Froyd wrote:

> - We should really be using inform_n, rather than some hacky
>   format-already-translated-strings-into-messages scheme;

Yes.

> - We shouldn't tell the user that we hit the max namespace limit if
>   there aren't any more namespaces to search.

Yes.

> - When suggesting alternatives, we should indicate the location of the
>   alternative we're suggesting rather than the location of the name we
>   failed to lookup.

Yes.

> OK with the above changes?

Yes.

Thank you,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]