This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH,c++] fix PR 45330, suggest alternatives for failed name lookups


On 12/4/2010 5:16 PM, Jason Merrill wrote:

> If you say %q+D in your error message, that means "use the locus of this
> decl as well as printing it."  That seems a lot more concise than having
> to write error_at (DECL_SOURCE_LOCATION (decl), "...%qD...", decl);

100% agreed.  "%q+D" is a good thing.

On the other hand, I do also agree that using input_location is not a
good thing; the locations for error messages should be driven by
something explicit (a declaration, or something else).

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]