This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix missing headers for plugin [was Miss head file diagnostic.h in plugin.h?]
- From: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>
- To: Joern Rennecke <amylaar at spamcop dot net>
- Cc: Mingjie Xing <mingjie dot xing at gmail dot com>, gcc-patches at gcc dot gnu dot org, "Joseph S. Myers" <joseph at codesourcery dot com>, Ehren Metcalfe <ehren dot m at gmail dot com>
- Date: Wed, 1 Dec 2010 07:57:36 +0100
- Subject: Re: [PATCH] Fix missing headers for plugin [was Miss head file diagnostic.h in plugin.h?]
- References: <20101130153446.1hlvr34i888osw4w-nzlynne@webmail.spamcop.net>
* Joern Rennecke wrote on Tue, Nov 30, 2010 at 09:34:46PM CET:
> Mingjie Xing:
> >2010/11/30 Ralf Wildenhues:
> >>But then why is hard-reg-set.h not listed in FUNCTION_H? ?Generally,
> >>the *_H make macros in gcc/Makefile.in should correspond to directly
> >>included headers only (with some set of exceptions that I haven't really
> >>grokked yet, sorry).
> >I bet you are right. Putting hard-reg-set.h in FUNCTION_H seems
> >reasonable. Here's the updated patch.
>
> The problem is that function.h depends on a target-dependent type.
> See PR middle-end/46495
Are you suggesting that r167290 should be reverted for now?
Thanks,
Ralf