This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch lto/c++/middle-end/windows]: Fix handling of dllexport for LTO as externally_visible
- From: Kai Tietz <ktietz70 at googlemail dot com>
- To: Kai Tietz <Kai dot Tietz at onevision dot com>
- Cc: Dave Korn <dave dot korn dot cygwin at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <hubicka at ucw dot cz>, jason at redhat dot com, Andrew Pinski <pinskia at gmail dot com>, Richard Guenther <richard dot guenther at gmail dot com>
- Date: Tue, 30 Nov 2010 09:25:53 +0100
- Subject: Re: [patch lto/c++/middle-end/windows]: Fix handling of dllexport for LTO as externally_visible
- References: <4CF41A39.50101@gmail.com> <OF7593B431.69DAE199-ONC12577EB.002D7DEA-C12577EB.002D90CC@onevision.de>
2010/11/30 Kai Tietz <Kai.Tietz@onevision.com>:
> Dave Korn <dave.korn.cygwin@gmail.com> wrote on 29.11.2010 22:25:13:
>
>> On 29/11/2010 20:59, Andrew Pinski wrote:
>> > On Mon, Nov 29, 2010 at 1:20 PM, Dave Korn <dave.korn.
>> cygwin@gmail.com> wrote:
>> >> gcc/ChangeLog:
>> >>
>> >> 2010-11-29 ?Dave Korn ?<...
>> >>
>> >> ? ? ? ?* cgraphunit.c (process_function_and_variable_attributes): Fix
>> >> ? ? ? ?cut'n'pasteo.
>> >>
>> >> ?OK, I take it?
>> >
>> > I think this is the same as PR 46709.
>> >
>> > -- Pinski
>>
>> ? Yep, I'm sure it is. ?I'll mention it in the changelog when I commit.
>>
>> ? ? cheers,
>> ? ? ? DaveK
>>
>
> Yes, this is a pasto and pretty obvious.
Suggested patch should fix this issue
PR middle-end/46709
* cgraphunit.c (process_function_and_variable_attributes): Fix typo.
Ok for apply?
Kai
--
|? (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination
Index: cgraphunit.c
===================================================================
--- cgraphunit.c (revision 167290)
+++ cgraphunit.c (working copy)
@@ -844,7 +844,7 @@
}
if (TARGET_DLLIMPORT_DECL_ATTRIBUTES
&& lookup_attribute ("dllexport", DECL_ATTRIBUTES (decl))
- && TREE_PUBLIC (node->decl))
+ && TREE_PUBLIC (vnode->decl))
{
if (vnode->finalized)
varpool_mark_needed_node (vnode);