This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix missing headers for plugin [was Miss head file diagnostic.h in plugin.h?]

From: Mingjie Xing <mingjie dot xing at gmail dot com>
To: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>, Mingjie Xing <mingjie dot xing at gmail dot com>, gcc-patches at gcc dot gnu dot org, "Joseph S. Myers" <joseph at codesourcery dot com>, Ehren Metcalfe <ehren dot m at gmail dot com>
Date: Tue, 30 Nov 2010 15:14:49 +0800
Subject: Re: [PATCH] Fix missing headers for plugin [was Miss head file diagnostic.h in plugin.h?]
References: <AANLkTint25UQMn=Q5_d7QP7p4_7h3Wz5ks5eyPJMyYF=@mail.gmail.com> <20101129223850.GH21955@gmx.de> <AANLkTik4ztZmy7u26T1Oom1WWA=RPNi8PWdKi6wwoO-C@mail.gmail.com> <20101130055812.GA3713@gmx.de> <AANLkTik13Q-tPtxCp9ayTNEgRggtA4VU2rC6wFzPkv7Z@mail.gmail.com>

> 2010/11/30 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>:
>> * Mingjie Xing wrote on Tue, Nov 30, 2010 at 02:43:45AM CET:
>>> 2010/11/30 Ralf Wildenhues:
>>> > But then why is hard-reg-set.h not listed in FUNCTION_H? ?Generally,
>>> > the *_H make macros in gcc/Makefile.in should correspond to directly
>>> > included headers only (with some set of exceptions that I haven't really
>>> > grokked yet, sorry).
>>
>>> I bet you are right. Putting hard-reg-set.h in FUNCTION_H seems
>>> reasonable. ?Here's the updated patch.
>>>
>>> Bootstrapped on ia64-redhat-linux and i486-linux-gnu.
>>
>> OK then.
>>
>> Thanks,
>> Ralf

Committed revision 167290.

Thanks,
Mingjie

References:
- [PATCH] Fix missing headers for plugin [was Miss head file diagnostic.h in plugin.h?]
  - From: Mingjie Xing
- Re: [PATCH] Fix missing headers for plugin [was Miss head file diagnostic.h in plugin.h?]
  - From: Ralf Wildenhues
- Re: [PATCH] Fix missing headers for plugin [was Miss head file diagnostic.h in plugin.h?]
  - From: Mingjie Xing
- Re: [PATCH] Fix missing headers for plugin [was Miss head file diagnostic.h in plugin.h?]
  - From: Ralf Wildenhues
- Re: [PATCH] Fix missing headers for plugin [was Miss head file diagnostic.h in plugin.h?]
  - From: Mingjie Xing

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]