This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix missing headers for plugin [was Miss head file diagnostic.h in plugin.h?]


2010/11/30 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>:
> * Mingjie Xing wrote on Tue, Nov 30, 2010 at 02:43:45AM CET:
>> 2010/11/30 Ralf Wildenhues:
>> > But then why is hard-reg-set.h not listed in FUNCTION_H? ?Generally,
>> > the *_H make macros in gcc/Makefile.in should correspond to directly
>> > included headers only (with some set of exceptions that I haven't really
>> > grokked yet, sorry).
>
>> I bet you are right. Putting hard-reg-set.h in FUNCTION_H seems
>> reasonable. ?Here's the updated patch.
>>
>> Bootstrapped on ia64-redhat-linux and i486-linux-gnu.
>
> OK then.
>
> Thanks,
> Ralf

Hi Ralf, further digging shows that there are many places where
hard-reg-set.h and $(FUNCTION_H) both appear.  For an example,

graph.o: graph.c $(SYSTEM_H) coretypes.h $(TM_H) $(TOPLEV_H)
$(DIAGNOSTIC_CORE_H) $(FLAGS_H) output.h \
    $(RTL_H) $(FUNCTION_H) hard-reg-set.h $(BASIC_BLOCK_H) graph.h
$(OBSTACK_H) \
    $(CONFIG_H) $(EMIT_RTL_H)

Do you think that after put hard-reg-set.h in FUNCTION_H, these will
need more cleanup?

Thanks,
Mingjie


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]