This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] introduce __FLOAT_WORD_ORDER__ in lieu of LIBGCC2_FLOAT_WORDS_BIG_ENDIAN


On Sat, 27 Nov 2010, Nathan Froyd wrote:

> > Which was about a missing include "tm_p.h".
> > 
> > May be there's a better way to fix this once and for all 
> > rather than adding another missing include?
> 
> Sorry about the breakage.  I should have double-checked this on ARM.  I
> don't know that there's any better way to fix this at the moment than
> including tm_p.h in cppbuiltin.c.

The better way of avoiding a tm_p.h include is usually a target hook 
conversion of the relevant target macro (FLOAT_WORDS_BIG_ENDIAN).  In the 
present case, the hook already exists purely as a targhooks.c wrapper to 
the macro; all the remaining users of the macro need to be converted to 
the hook before any targets can define the hook in place of the macro (but 
cppbuiltin.c could be changed on its own to use the hook like 
java/jcf-parse.c, without any of the other changes).

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]