This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix up maybe_cleanup_end_of_block (PR middle-end/46499)
On Tue, Nov 23, 2010 at 5:00 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Tue, Nov 23, 2010 at 04:51:35PM -0800, H.J. Lu wrote:
>> > --- gcc/cfgexpand.c.jj ?2010-11-10 13:14:53.000000000 +0100
>> > +++ gcc/cfgexpand.c ? ? 2010-11-22 14:45:49.000000000 +0100
>> > @@ -1694,7 +1694,14 @@ maybe_cleanup_end_of_block (edge e, rtx
>> > ? ? ? ?{
>> > ? ? ? ? ?insn = PREV_INSN (insn);
>> > ? ? ? ? ?if (JUMP_P (NEXT_INSN (insn)))
>> > - ? ? ? ? ? delete_insn (NEXT_INSN (insn));
>> > + ? ? ? ? ? {
>> > + ? ? ? ? ? ? if (!any_condjump_p (insn))
>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?^^^^^^ Shouldn't it
>> be any_condjump_p (NEXT_INSN (insn))
>
> Oops.
> No, but either if (!any_condjump_p (NEXT_INSN (insn)))
> or if (any_uncondjump_p (NEXT_INSN (insn)))
>
> I'll bootstrap/regtest the former now.
Please add the testcase in
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46629
Thanks.
--
H.J.