This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Properly check the end of basic block
On Thu, Nov 18, 2010 at 11:24 PM, Jakub Jelinek <jakub@redhat.com> wrote:
>> 2010-11-18 ?Uros Bizjak ?<ubizjak@gmail.com>
>>
>> ? ? ? PR middle-end/46546
>> ? ? ? * passes.c (init_optimization_passes): Move machine_reorg pass before
>> ? ? ? free_cfg pass.
>>
>> Tested on x86_64-pc-linux-gnu {,-m32}. OK for mainline and release branches?
>
> I'm afraid this is going to break various targets, such change can't be
> taken lightly and testing just on 2 targets is definitely not sufficient.
>
> Definitely not something that should be applied ever to release branches,
> not sure if it is something that should be done in stage3 for 4.6.
Note taken.
> Targets that need cfg in the reorg pass compute it themselves (e.g. ia64),
> other targets could depend on that the CFG is gone.
>
> Why does i?86 actually care about CFG in its reorg pass, unlike targets
> that do scheduling etc. I don't see why it should care.
Just for the sole delete_insn of the insn at the BB_END in
ix86_pad_returns. We can in fact manually update BB_END, as H.J.
proposed.
Uros.