This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix -flto=N parsing
- From: Andrew Pinski <pinskia at gmail dot com>
- To: Richard Guenther <rguenther at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 18 Nov 2010 12:44:27 -0800
- Subject: Re: [PATCH] Fix -flto=N parsing
- References: <alpine.LNX.2.00.1011181214230.23074@zhemvz.fhfr.qr>
On Thu, Nov 18, 2010 at 3:17 AM, Richard Guenther <rguenther@suse.de> wrote:
>
> This fixes an oversight when doing s/-fwhopr/-flto/, the character
> index of =N parsing didn't get updated.
> ! Â Â Â Â Â Â Â Â Â parallel = atoi (option + 6);
Should we be using atoi here? I think we should use strtol instead
and check for errors in decoding of the number.
Thanks,
Andrew Pinski