This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/3] Fix PR46029: reimplement if-convert stores.


On Tue, 16 Nov 2010, Richard Guenther wrote:

> On Mon, 15 Nov 2010, Sebastian Pop wrote:
> 
> > Hi Richi,
> > 
> > fixes to your review are posted separately, see below for the details.
> > See 0001-Fix-PR46029-reimplement-if-convert-stores.patch for the
> > combined patch.
> 
> +  tree base = create_tmp_var (array_type, "scratch_pad");
> +  tree a0 = build4 (ARRAY_REF, elt_type, base, integer_zero_node, 
> NULL_TREE,
> +                   NULL_TREE);
> 
> you can drop creating the ARRAY_REF and do
> 
> +  return insert_address_of (base, build_pointer_type (elt_type), &gsi);
> 
> 
> The patches are ok with the above change.

Btw, in insert_address_of you might want to add

  struct ptr_info_def *pi = get_ptr_info (address_of_ai);
  pt_solution_set_var (&pi->pt, SSA_NAME_VAR (address_of_ai));

Richard.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]